Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdump: don't write extension twice in clustermesh debug files #2557

Merged
merged 1 commit into from
May 17, 2024

Conversation

giorio94
Copy link
Member

Let's avoid to report the file extension twice, as in

  clustermesh-apiserver-5dc46d9cf7-cg5db-kvstoremesh-troubleshoot-txt-20240517-150749.txt

as redundant. The correct version would be

  clustermesh-apiserver-5dc46d9cf7-cg5db-kvstoremesh-troubleshoot-20240517-150749.txt

Fixes: 7029b16 ("sysdump: collect clustermesh-related debug information")

Let's avoid to report the file extension twice, as in
  clustermesh-apiserver-5dc46d9cf7-cg5db-kvstoremesh-troubleshoot-txt-20240517-150749.txt,
as redundant. The correct version would be
  clustermesh-apiserver-5dc46d9cf7-cg5db-kvstoremesh-troubleshoot-20240517-150749.txt.

Fixes: 7029b16 ("sysdump: collect clustermesh-related debug information")
Signed-off-by: Marco Iorio <[email protected]>
@giorio94 giorio94 requested a review from a team as a code owner May 17, 2024 13:39
@giorio94 giorio94 requested a review from derailed May 17, 2024 13:39
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giorio94 Great catch Marco!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 17, 2024
@michi-covalent michi-covalent merged commit bbe1129 into cilium:main May 17, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants