connectivity: Delete test-conn-disrupt pods immediately after test run #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
force-pushed
the
pr/brb/early-terminate-conn-disrupt
branch
from
5d01c79 to
26a4bb8
Compare
brb
changed the title
|
Blocked by #2513. |
giorio94
reviewed
Apr 30, 2024
brb
force-pushed
the
pr/brb/early-terminate-conn-disrupt
branch
from
26a4bb8 to
1ff5b5d
Compare
It's going to be passed by test-conn-disrupt pods deletion finalizer in a subsequent commit. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/early-terminate-conn-disrupt
branch
from
1ff5b5d to
0a20b49
Compare
brb
force-pushed
the
pr/brb/early-terminate-conn-disrupt
branch
from
0a20b49 to
72c9b93
Compare
Otherwise, we risk to end up with not properly cleaning all installed resource. Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/early-terminate-conn-disrupt
branch
from
72c9b93 to
6b33813
Compare
giorio94
reviewed
Apr 30, 2024
| // Use a detached context to make sure this call is not affected by | ||
| // context cancellation. Usually, finalization (e.g., netpol removal) | ||
| // needs to happen even when the user interrupted the program. | ||
| if err := f(context.TODO()); err != nil { |
There was a problem hiding this comment.
I wonder if it could make sense to add a timeout to prevent finalizers from hanging forever in case of e.g., network connectivity problems.
There was a problem hiding this comment.
What could be a reasonable timeout? 5min?
There was a problem hiding this comment.
Hmm, I was actually thinking about a way lower value (something between 1 and 5 seconds), but it may be indeed to low if we are waiting for any operation to actually happen (like in case of policies removal). Maybe 1 minute?
Delete the test-conn-disrupt pods immediately after the test run has finished to reduce CPU consumption (the pods generate a lot of traffic, and in most CI jobs Cilium runs with monitor aggregation disabled). Suggested-by: Marco Iorio <[email protected]> Signed-off-by: Martynas Pumputis <[email protected]>
brb
force-pushed
the
pr/brb/early-terminate-conn-disrupt
branch
from
6b33813 to
0b6aeec
Compare
michi-covalent
added
the
priority/release-blocker
christarazi
approved these changes
Apr 30, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs.
Test runs: cilium/cilium#32234