connectivity: misc conn-disrupt-test improvements #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
force-pushed
the
mio/test-conn-disrupt-image-configurable
branch
from
5552648 to
30e3511
Compare
giorio94
changed the title
Simplify testing of new versions, as well as allow pulling the image from a different mirror repository. Signed-off-by: Marco Iorio <[email protected]>
Additionally adapt the dispatch interval parameter value to directly propagate the duration value, to account for its change [1]. [1]: cilium/test-connection-disruption@baebb9c Signed-off-by: Marco Iorio <[email protected]>
In an effort to reduce flakiness, let's configure CPU requests for connectivity disruption pods, to prevent them from stalling (and consequently restarting) due to CPU starvation. Requests are currently configured to 100m CPU, which should be enough to guarantee prompt responses within the 1 second deadline, without demanding at the same time for excessive resources. Signed-off-by: Marco Iorio <[email protected]>
giorio94
force-pushed
the
mio/test-conn-disrupt-image-configurable
branch
from
30e3511 to
89d6801
Compare
tklauser
approved these changes
Apr 16, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit, and refer to the individual messages for additional details. Brief summary follows: