Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: Remove Tetragon client #2463

Merged
merged 1 commit into from
Apr 1, 2024
Merged

k8s: Remove Tetragon client #2463

merged 1 commit into from
Apr 1, 2024

Conversation

michi-covalent
Copy link
Contributor

Following up on #2387, remove the Tetragon dependency completely. There is no need to add Tetragon types to the default scheme since the sysdump now uses ListUnstructured to get Tetragon-related custom resources.

@michi-covalent
k8s: Remove Tetragon client
f4d2eb5 
Following up on #2387, remove
the Tetragon dependency completely. There is no need to add Tetragon
types to the default scheme since the sysdump now uses ListUnstructured
to get Tetragon-related custom resources.

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent
Copy link
Contributor Author

tested manually ✅

% ./cilium sysdump
% unzip cilium-sysdump-20240401-012344.zip
% cat cilium-sysdump-20240401-012344/tetragontracingpolicy*
apiVersion: cilium.io/v1alpha1
items:
- apiVersion: cilium.io/v1alpha1
  kind: TracingPolicy
  metadata:
    ...
  spec:
    kprobes:
    - args:
      - index: 0
        maxData: false
        returnCopy: false
        type: file
  ...

@michi-covalent michi-covalent marked this pull request as ready for review April 1, 2024 01:27
@michi-covalent michi-covalent requested review from a team as code owners April 1, 2024 01:27
kkourt
kkourt approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 1, 2024
@michi-covalent michi-covalent merged commit d0c8eb4 into main Apr 1, 2024
14 checks passed
@michi-covalent michi-covalent deleted the pr/michi/even-more-cleanup branch April 1, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@kkourt kkourt kkourt approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michi-covalent @kkourt @sayboras