Fix power-select with closeOnSelect=false nested within basic-dropdown #1512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding
aria-controls
on the dropdown trigger causes issues when a power-select is nested within a basic-dropdown and@closeOnSelect={{false}}
is set on the power-select. Specifically, the parent dropdown is erroneously closed when an option is selected. This change was introduced in bb1b8e9 as part of #1481.cibernox/ember-basic-dropdown#633 is the ember-basic-dropdown PR that made it not ok to override
aria-controls
since it uses this to build a relationship between the trigger and content.Repro: https://github.com/jamescdavis/power-select-nested-dropdown-repro/blob/main/app/templates/application.hbs
(this repro uses
PowerSelectMultiple
but the behavior is the same forPowerSelect
)This PR adds a failing test for the issue along with a couple of smoke tests for nested power-select. It also includes a commit that simply removes the
aria-controls
override, which makes the failing tests pass and resolves the bug, but I'm sure is not the desired resolution (and obviously makes a11y tests fail). I am as of yet uncertain how to fix this properly.