Adding ability to override defaults in config #1034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a proof of concept to see if you are happy with the idea, and if so we can extend it to all/any of the parameters you want to be able to set the defaults for in config.
The basic idea here is: you have a sensible default set for
matchTriggerWidth
on ember-power-select but I need this default to be different for all instances of ember-power-select across my codebase.Using a trick similar to we use in ember-cli-notifications I have been able to test this locally with a linked ember-power-select. If you like the idea I can (try) implement some tests using https://github.com/tomdale/ember-cli-addon-tests.