Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all valid options on to the power-select component and update packages, tests, and add yarn.lock #10

Merged
merged 1 commit into from
May 17, 2018
Merged

Pass all valid options on to the power-select component and update packages, tests, and add yarn.lock #10

merged 1 commit into from
May 17, 2018

Conversation

nbrookie
Copy link
Contributor

@nbrookie nbrookie commented May 16, 2018 •
edited
Loading

Giving ember-power-select-blockless some love ❤️

  • Updates packages
  • Adds a yarn.lock
  • Updates component tests to new async syntax
  • Pass all valid options from the blockless component to the power-select component.

@nbrookie nbrookie force-pushed the update-packages branch 2 times, most recently from 99e04f9 to 5ef452c Compare May 17, 2018 16:03
@nbrookie
Copy link
Contributor Author

nbrookie commented May 17, 2018 •
edited
Loading

Hmmm, build failure seems to be related to emberjs/ember.js#16387, a new assertion in ember v3.2.0-beta.1

Weird because the ember-power-select build is currently passing and it is also testing against ember-beta. Any ideas?

@nbrookie
Pass all power-select options and update packages, tests, add yarn.lock
a778ea8 
- Pass all valid options on to the power-select component
- Update everything to the latest ember version
@nbrookie nbrookie changed the title Update packages, tests, and add yarn.lock Pass all valid options on to the power-select component and update packages, tests, and add yarn.lock May 17, 2018
@nbrookie nbrookie mentioned this pull request May 17, 2018
Closed
@cibernox
Copy link
Owner

This is weird. I'm going to merge it and check what is going later.

@cibernox cibernox merged commit b29f67b into cibernox:master May 17, 2018
@cibernox
Copy link
Owner

Thanks!

@nbrookie nbrookie mentioned this pull request May 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbrookie @cibernox