Nav refactor stock #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Hixie
reviewed
Jul 16, 2020
Hixie
reviewed
Jul 16, 2020
There was a problem hiding this comment.
nit:style guide says to only give library when there's docs
Hixie
reviewed
Jul 16, 2020
goderbauer
reviewed
Jul 16, 2020
There was a problem hiding this comment.
this import shouldn't be necessary?
Comment on lines
152
to
150
There was a problem hiding this comment.
Suggested change
| } else { | |
| if (syntheticUrl.path == '/stock') { | |
| final String symbol = syntheticUrl.queryParameters['symbol']; | |
| if (symbol != null && symbol.isNotEmpty) | |
| return SynchronousFuture<StockRoutePath>(StockSymbolPath(symbol)); | |
| } | |
| return SynchronousFuture<StockRoutePath>(const StockHomePath()); | |
| } | |
| } | |
| if (syntheticUrl.path == '/stock') { | |
| final String symbol = syntheticUrl.queryParameters['symbol']; | |
| if (symbol != null && symbol.isNotEmpty) | |
| return SynchronousFuture<StockRoutePath>(StockSymbolPath(symbol)); | |
| } | |
| return SynchronousFuture<StockRoutePath>(const StockHomePath()); |
There was a problem hiding this comment.
maybe define these strings as const on the class to reuse them here and in the method below?
There was a problem hiding this comment.
What does null mean? Should there be an assert because configuration is always one of the options?
Comment on lines
197
to
198
chunhtai
force-pushed
the
nav-refactor-router-alone
branch
from
da0c469 to
512f2d9
Compare
johnpryan
reviewed
Jul 21, 2020
chunhtai
force-pushed
the
nav-refactor-router-alone
branch
9 times, most recently
from
e3f6b1f to
698bc81
Compare
chunhtai
force-pushed
the
nav-refactor-router-alone
branch
8 times, most recently
from
9a2d2fd to
0b113e9
Compare
chunhtai
force-pushed
the
nav-refactor-stock
branch
from
5439a6c to
139c18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stocks app rewrite using router widget
router pr flutter#60299
Related Issues
flutter#45938
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.