Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests/max-length #129

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Add tests/max-length #129

merged 1 commit into from
Nov 12, 2020

Conversation

chubin
Copy link
Owner

@chubin chubin commented Nov 11, 2020

Add tests/max-length testing length of cheat sheets comment lines.
Can be used interactively:

    $ tests/max-length

@chubin chubin merged commit fd0cb41 into master Nov 12, 2020
@terminalforlife
Copy link
Contributor

I think I'm missing something. Why are you sending yourself PRs?

@chubin
Copy link
Owner Author

chubin commented Nov 12, 2020

Actually, the original idea was to open this PR and give it to your for review, but for that you need to be a collaborator in this project. I tried to add you as a collaborator, but you didn't accept the invitation, so I decided that there should be some reasons for that, so I merged the pull-request.

Also, another quite typical reason to open pull-requests is to make the automatic CI checks be automatically executed (it is irrelevant in this repository though, because we have no automatic CI checks currently).

@terminalforlife
Copy link
Contributor

terminalforlife commented Nov 12, 2020

Oooh! That makes sense. Thanks for explaining. Regarding the collaborator thing, see this link. Oh, and I can still submit reviews, despite not being a collaborator.

Selectshot_2020-11-12_16:24:46

Unless you mean something different than what the 'Review changes' button offers.

@chubin
Copy link
Owner Author

chubin commented Nov 12, 2020

Oh, sorry, I missed this part. I am not sure that I understood what you meant about anonymity, because I didn’t think that it could be somehow affected with it. I think, the most important change is that you can make merges and be added as a reviewer to pull-requests

To say the truth I don’t understand why GitHub doesn’t allow to invite someone for a review if he is not a collaborator, but it is ok, one can use mentions instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants