Encode values to bytes in Python 3 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopuhin
added a commit
that referenced
this pull request
Dec 18, 2015
Encode values to bytes in Python 3
|
Thank you! |
|
Thanks! On Fri, Dec 18, 2015 at 8:40 AM, Konstantin Lopuhin <
Greg White |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a problem in GeoDjango in python 3, where the Geo objects are coming in as objects and are converted for the DB as strings. By forcing encoding, we ensure that they are able to be inserted.
Without the encoding change, the final join (return b''.join(parts)) will fail with a type conversion error.