Add parameter to control BlueZ data duplication while scanning #82
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianhaas
force-pushed
the
add-duplicate-data-parameter-to-discovery-filter
branch
from
e72a8fa to
fea094f
Compare
|
Hi @chrvadala, I just wanted to follow up on this pull request, which I submitted a while ago. Whenever you have a moment, I'd love to get your thoughts on it. Let me know if there's anything I can adjust or improve to help move it forward. Thanks in advance for your time and consideration! Looking forward to your feedback. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the option to control BlueZ's data duplication according to https://github.com/bluez/bluez/blob/4465c577778d812702d752dfd2812e25a2f69b31/doc/org.bluez.Adapter.rst?plain=1#L128
While de-duplication seems to be off on a few distributions, it is on on others, essentially making continous monitoring of advertised data impossible. Also, since the offizial BlueZ documentation regarded
trueto be the default for duplicate data, I set this option totrueas default for node-ble as well in order to preserve what I believe was the intended default operation until this point.Related to this, documentation on DuplicateData was outdated and has now been changed: bluez/bluez#1113
I also updated the API documentation and TypeScript typings accordingly.