Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript Client Request Issue #66

Open
jbspears opened this issue May 12, 2022 · 2 comments
Open

Javascript Client Request Issue #66

jbspears opened this issue May 12, 2022 · 2 comments

Comments

@jbspears
Copy link

Looks like the client _requests_by_id and _requests_by_timestamp are Map objects and should use set/get. Also, the timeout passed to the request method is multiplied by 1000000. I would think since the timestamp is milliseconds and the timeout is milliseconds that no conversion would be needed. Once I modified the Map objects to use set/get and removed the timeout multiplier, the client request seemed to work as expected. Thanks.
@chronoxor
Copy link
Owner

Will look into this issue! Thanks for reporting!

chronoxor pushed a commit that referenced this issue May 19, 2022
Javascript Client Request Issue #66
496d036
@chronoxor
Copy link
Owner

Fixed! Thanks for reporting! Can you please check the fix on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chronoxor @jbspears