TimeZone::from_posix_tz: Treat empty TZ variable as UTC#1691
Merged
djc merged 1 commit intochronotope:mainfrom Apr 5, 2025
Merged
TimeZone::from_posix_tz: Treat empty TZ variable as UTC#1691djc merged 1 commit intochronotope:mainfrom
djc merged 1 commit intochronotope:mainfrom
Conversation
This is not technically POSIX, but glibc and musl behave that way: e.g. `TZ= date` returns a UTC date.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
==========================================
+ Coverage 90.62% 90.67% +0.04%
==========================================
Files 38 38
Lines 16871 16872 +1
==========================================
+ Hits 15290 15299 +9
+ Misses 1581 1573 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
approved these changes
Apr 5, 2025
Member
|
Thanks! |
Contributor
Author
|
@djc not terribly urgent, but any chance we could get a release with this sometimes soon? Would be useful for uutils/coreutils. Thanks! |
Contributor
Author
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not technically POSIX, but glibc and musl behave that way: e.g.
TZ= datereturns a UTC date.Fixes #1690.