Convert time-related with_* methods to return Result
#1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1498 +/- ##
==========================================
- Coverage 94.11% 94.04% -0.08%
==========================================
Files 37 37
Lines 17125 17019 -106
==========================================
- Hits 16118 16005 -113
- Misses 1007 1014 +7 ☔ View full report in Codecov by Sentry. |
djc
reviewed
Mar 11, 2024
src/naive/datetime/mod.rs
Outdated
| @@ -987,7 +987,7 @@ impl NaiveDateTime { | |||
| /// ``` | |||
| #[inline] | |||
| pub const fn with_minute(&self, min: u32) -> Option<NaiveDateTime> { | |||
| Some(NaiveDateTime { time: try_opt!(self.time.with_minute(min)), ..*self }) | |||
| Some(NaiveDateTime { time: try_opt!(ok!(self.time.with_minute(min))), ..*self }) | |||
There was a problem hiding this comment.
Why don't we have a try_ok_opt!() or whatever macro?
There was a problem hiding this comment.
They could have use that macro also. It was only there to split up the commits, and replaced in a later commit.
djc
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
NaiveTime::{with_hour, with_minute, with_second, with_nanosecond}andNaiveDateTime::{with_hour, with_minute, with_second, with_nanosecond}to returnResult.This turned out to be a refreshingly mechanical change.
I took the opportunity to use
?in the doctests of the relevant methods.At some point when we are a bit further along we should convert more doctests and regular tests to use
?.cc @Zomtir