Refactor internals module part 2
#1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
changed the title
internals module part 1internals module part 2
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
==========================================
- Coverage 91.85% 91.84% -0.02%
==========================================
Files 38 38
Lines 17657 17628 -29
==========================================
- Hits 16219 16190 -29
Misses 1438 1438 ☔ View full report in Codecov by Sentry. |
pitdicker
force-pushed
the
refactor_internals_2
branch
from
adbfc7a
to
c3c39eb
Compare
djc
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These four commits are somewhat related as they all work on the ordinal part of a
NaiveDate, or the ordinal + leap year flag (ol).