CI Linting: Fix missing sources checkout in toml
job.
#1371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I saw that this project runs a toml job during the CI lint workflow using
taplo
, but I suspect that it will always succeed given that no projects files have been checked out.chrono/.github/workflows/lint.yml
Lines 32 to 39 in 5aaf742
Example output from https://github.com/chronotope/chrono/actions/runs/7355211902/job/20023493157:
Here's the job I'm using on a personal project:
Which results in the following output:
Above indicates that the
taplo.toml
config was found, which should betaplo.toml
forchrono
, but also that a non-zero amount of toml files were in fact checked.It's such a small fix that I couldn't be bothered to open up an issue first, hope that's ok ✌️
Update:
Result from PR action: