improve doc comment and tests for timestamp_nanos_opt #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The doc comment for `DateTime::timestamp_nanos_opt` incorrectly described a panic, which is actually an error. - The lower and upper limits of valid timestamps were not precise (both for `DateTime` and `NaiveDateTime` and both `timestamp_nanos` and `timestamp_nanos_opt`). This commit adds the precise limits to all methods and doctests for those limits to `DateTime::timestamp_nanos_opt`.
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1299 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 38 38
Lines 17034 17042 +8
=======================================
+ Hits 15562 15570 +8
Misses 1472 1472
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime::timestamp_nanos_opt(added in Addtimestamp_nanos_opt, deprecatetimestamp_nanos#1275) incorrectly described a panic, which is actually an error.DateTimeandNaiveDateTimeand bothtimestamp_nanosandtimestamp_nanos_opt). This commit adds the precise limits to all methods and doctests for those limits toDateTime::timestamp_nanos_opt.