Format day in RFC 2822 without padding #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1272 +/- ##
=======================================
Coverage 91.40% 91.41%
=======================================
Files 38 38
Lines 16932 16939 +7
=======================================
+ Hits 15477 15484 +7
Misses 1455 1455
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
djc
approved these changes
Sep 11, 2023
andy128k
added a commit
to rust-syndication/rss
that referenced
this pull request
Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k
added a commit
to rust-syndication/rss
that referenced
this pull request
Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k
added a commit
to rust-syndication/rss
that referenced
this pull request
Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k
added a commit
to rust-syndication/rss
that referenced
this pull request
Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
andy128k
added a commit
to rust-syndication/rss
that referenced
this pull request
Jan 13, 2024
Chrono changed day formatting in 0.4.31 chronotope/chrono#1272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime::to_rfc2822would format the day value with space padding when #249 was opened. #844 changed it to zero padding, probably unintentionally. No padding at all seems more in line with the standard.We had no test for this case.
Fixes #1269.