Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Timelike::num_seconds_from_midnight is a simple mapping #1255

Merged

Conversation

pitdicker
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1255 (8f118fe) into 0.4.x (e39346e) will decrease coverage by 0.04%.
Report is 9 commits behind head on 0.4.x.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.4.x    #1255      +/-   ##
==========================================
- Coverage   91.41%   91.37%   -0.04%     
==========================================
  Files          37       37              
  Lines       16452    16448       -4     
==========================================
- Hits        15040    15030      -10     
- Misses       1412     1418       +6     
Files Changed Coverage Δ
src/traits.rs 92.59% <ø> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/traits.rs Outdated
/// Every value in 00:00:00-23:59:59 maps to an integer in 0-86399.
///
/// This method is not intended to provide the real number of seconds since midnight on a given
/// day. It does not take things into account such as a DST transition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last sentence feels a bit awkward? I'd rewrite this last sentence as "It does not take things like DST transitions into account.", what do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is better 👍

@pitdicker pitdicker merged commit f4aefc7 into chronotope:0.4.x Sep 6, 2023
37 checks passed
@pitdicker pitdicker deleted the num_seconds_from_midnight_doc branch September 6, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants