Fix locale formatting for %c and %r
#1058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`%c`: did not take account of `%x` and `%X` `%r`: did not use locale's format and used `%I:%M:%S %p`
feature parity with gnu date
t_fmt_ampm should be lower than t_fmt
|
The CI failures are not related to this PR. Edit: not all were 😄 |
jtmoon79
suggested changes
May 12, 2023
scarf005
commented
May 12, 2023
Co-authored-by: Paul Dicker <[email protected]>
jtmoon79
suggested changes
May 13, 2023
* docs: missing `a` * docs: more descriptive link
This was referenced Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ko_KR) #985changed to target
0.4.xinstead of main in Fix locale formatting for%cand%r#988