Make ParseError a real Error enum
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. The new CI test with |
|
Found a workaround: package without verification, extract to a directory with vendored crates, verify against vendored instead of crates.io. Thanks to rust-lang/cargo#1169 (comment). |
djc
approved these changes
Apr 5, 2024
chrono-tz-build/src/lib.rs
Outdated
| #[cfg(not(feature = \"std\"))] | ||
| pub type ParseError = &'static str; | ||
| r#"#[derive(Copy, Clone, Debug, PartialEq, Eq)] | ||
| pub struct ParseError; |
There was a problem hiding this comment.
Let's do ParseError(()) to avoid it being constructed by external callers?
chrono-tz/Cargo.toml
Outdated
| @@ -42,7 +42,7 @@ filter-by-regex = ["chrono-tz-build/filter-by-regex"] | |||
| case-insensitive = ["dep:uncased", "chrono-tz-build/case-insensitive", "phf/uncased"] | |||
|
|
|||
| [build-dependencies] | |||
| chrono-tz-build = { path = "../chrono-tz-build", version = "0.2.1" } | |||
| chrono-tz-build = { path = "../chrono-tz-build", version = "0.3.0" } | |||
|
I'll wait with merging to make #162 part of the new versions. |
|
Published 🎉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To continue #122 by @laralove143.
I added a second error type that is used when deserializing, which can borrow the input string and print a nice message (without needing to allocate).
Fixes @121.