Revert "[FEATURE] buffered channel drain next"#44
Merged
niedbalski merged 1 commit intomainfrom Sep 15, 2023
Merged
Conversation
Contributor
|
What plugin and/or configuration necessitated the revert? I have tested on both linux amd64 and arm64 without problems. Here is a dump of gdummy running on linux amd64: hydra ✘ ~/P/w/f/p/lts-advanced-plugin-dummy pwhelan-calyptia-plugin-drain-buffer ± core-fluent-bit-23.9.7 -c local.conf | head
Calyptia Core v23.9, patch_level=7
* https://calyptia.com
[2023/09/15 12:45:35] [ info] [calyptia core] version=23.9, patch=7, pid=40559
[2023/09/15 12:45:35] [ info] [storage] ver=1.4.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/09/15 12:45:35] [ info] [cmetrics] version=0.6.3
[2023/09/15 12:45:35] [ info] [ctraces ] version=0.3.1
[2023/09/15 12:45:35] [ info] [input:gdummy:gdummy.0] initializing
[2023/09/15 12:45:35] [ info] [input:gdummy:gdummy.0] storage_strategy='memory' (memory only)
[2023/09/15 12:45:35] [ info] [input:gdummy:gdummy.0] thread instance initialized
[2023/09/15 12:45:35] [ info] [sp] stream processor started
[2023/09/15 12:45:35] [ info] [output:stdout:stdout_output] worker #0 started
[0] gdummy.local: [[1694792736.437098018, {}], {"message"=>"dummy"}]
[1] gdummy.local: [[1694792736.437167531, {}], {"message"=>"dummy"}]
[2] gdummy.local: [[1694792736.437243943, {}], {"message"=>"dummy"}]
[3] gdummy.local: [[1694792736.437343686, {}], {"message"=>"dummy"}]
[4] gdummy.local: [[1694792736.437351516, {}], {"message"=>"dummy"}]
[5] gdummy.local: [[1694792736.437407278, {}], {"message"=>"dummy"}]
[6] gdummy.local: [[1694792736.437475290, {}], {"message"=>"dummy"}]
[7] gdummy.local: [[1694792736.437542832, {}], {"message"=>"dummy"}]
[8] gdummy.local: [[1694792736.437612374, {}], {"message"=>"dummy"}]
[9] gdummy.local: [[1694792736.437679236, {}], {"message"=>"dummy"}]
^C[2023/09/15 12:45:38] [engine] caught signal (SIGINT)
[2023/09/15 12:45:38] [ warn] [engine] service will shutdown in max 5 seconds
[2023/09/15 12:45:39] [ info] [engine] service has stopped (0 pending tasks)
[2023/09/15 12:45:39] [ info] [output:stdout:stdout_output] thread worker #0 stopping...
[2023/09/15 12:45:39] [ info] [output:stdout:stdout_output] thread worker #0 stopped
2023/09/15 12:45:39 calling FLBPluginExit(): name="gdummy" |
Contributor
|
@niedbalski Can you elaborate on why this patch did not work? Was it deployed with a core-fluent-bit binary that still has the overclocked input period? |
pwhelan
added a commit
that referenced
this pull request
Oct 5, 2023
Due to the revert in #44 I was unable to rebase #52 interactively so the changes will have to be applied in a single patch. This unfortunately means the loss of git history, but so be it. Here is the changelog: * test: add a sleep in the infinite call to give time for collect to be accidentally invoked after Done(). * input: invoke Collect only once and only ever once. Tests have been updated to enforce this behavior. * test: improve dangling test. * test: add latency test. Signed-off-by: Phillip Whelan <phil@calyptia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #43