Skip to content

v2 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 30, 2023
Merged

v2 #57

merged 10 commits into from
Mar 30, 2023

Conversation

nicolasparada
Copy link
Contributor

@nicolasparada nicolasparada commented Mar 17, 2023

Removing the plugin properties single item array, and instead place the properties directly, aka:

From:

pipeline:
  inputs:
    - dummy:
      name: dummy

To:

pipeline:
  inputs:
    - name: dummy

This is to align with fluent-bit new YAML format.

Also improved how IDs work by placing them directly on the struct instead of computing them each time.

Also added service port detection. This is so we can create the service ports on kubernetes. This is something we currently do on Cloud but it's not complete and some plugins don't generate a service port there, but now it should be up to date ;=)

I upgraded the go module name and added /v2 since this is a breaking change. We should do a data migration in Cloud from the old config format to this new one.

@nicolasparada nicolasparada marked this pull request as ready for review March 17, 2023 20:44
@nicolasparada nicolasparada requested a review from pwhelan March 17, 2023 20:44
@nicolasparada
Copy link
Contributor Author

CI takes around 10 seconds. Nice :D

@patrick-stephens
Copy link
Contributor

@jasmingacic let's get this merged if we can.

Copy link

@jasmingacic jasmingacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Merge it whenever you want

@patrick-stephens patrick-stephens merged commit 0f7b7a7 into main Mar 30, 2023
@patrick-stephens patrick-stephens deleted the v2 branch March 30, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants