-
Notifications
You must be signed in to change notification settings - Fork 1
v2 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v2 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI takes around 10 seconds. Nice :D |
patrick-stephens
suggested changes
Mar 20, 2023
patrick-stephens
approved these changes
Mar 20, 2023
@jasmingacic let's get this merged if we can. |
jasmingacic
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Merge it whenever you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the plugin properties single item array, and instead place the properties directly, aka:
From:
To:
This is to align with fluent-bit new YAML format.
Also improved how IDs work by placing them directly on the struct instead of computing them each time.
Also added service port detection. This is so we can create the service ports on kubernetes. This is something we currently do on Cloud but it's not complete and some plugins don't generate a service port there, but now it should be up to date ;=)
I upgraded the go module name and added
/v2
since this is a breaking change. We should do a data migration in Cloud from the old config format to this new one.