Fix json object output for INI. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dumping INI format, json objects were ignored, causing for the value of the entry to be discarded. This patch fixes that and adds a test to ensure parsing back and forth works correctly. Related to https://github.com/calyptia/cloud/issues/632 Signed-off-by: Jorge Niedbalski <[email protected]>
Signed-off-by: Jorge Niedbalski <[email protected]>
|
Thanks for the fix. Yesterday I found a way to replicate it too, but didn't submit the fix. Glad you found it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dumping INI format, json objects were ignored, causing for the value of the entry to be discarded.
This patch fixes that and adds a test to ensure parsing back and forth works correctly.
This is patch 1/2 to fix the issue related to https://github.com/calyptia/cloud/issues/632 reported by @eduardo
Signed-off-by: Jorge Niedbalski [email protected]