new parser

[nicolasparada]

Replacing the entire config parser with new code. This version does not use the participle library.

Instead, for the classic mode, it splits by line, and detects commands (@ prefix) and sections ([NAMED]). Then each property nested in a section is split by space. Simple.

It supports basic data types like string, integer, float and boolean. It does not try to parse regexes, dates, units, arrays, etc. Complex data types are left as string.

For the YAML parser, we use the yaml package with a custom unmarshaler to add support for sorted properties, so we don't loose track of the order of each property inside a plugin. This is mostly for testing so we can expect always the same order.

• classic config parser
• yaml config parser
• tests between them both
• support marshaling of multiline strings (|-)
• semantic schema validation
• json custom unmarshaler to preserve properties order too

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
3751481	Generic High Entropy Secret	e3f2eb0	tests/ini-to-json/11-s3-real.json	View secret
3751481	Generic High Entropy Secret	e3f2eb0	tests/ini-to-json/11-s3-real.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>

[nicolasparada]

@niedbalski this is still a WIP but can you take a look?

[niedbalski]

Great work.

Looks generally good. I think the parsing schema for json might be a bit fragile.

1. Did you remove the schema validator entirely from this parser?
2. Any chance you can re-instate the original tests? I am particularly interested
   into booleans, multi-field, urls (with schema + port + uri) and the multiple-files ones.

[nicolasparada]

1. I'm bringing the validator back.
2. I have already a good suite of tests, but sure I can add those :)