Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

property: fix panic in equality check of property value #104

Merged
merged 1 commit into from
Jul 31, 2024
Merged

property: fix panic in equality check of property value #104

merged 1 commit into from
Jul 31, 2024

Conversation

nicolasparada
Copy link
Contributor

Use reflect.DeepEqual to compare any instead of == that can cause a runtime panic:

runtime error: comparing uncomparable type []interface {}

[sc-102789]

pwhelan
pwhelan approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@pwhelan pwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasparada nicolasparada merged commit b875b1a into main Jul 31, 2024
1 check passed
@nicolasparada nicolasparada deleted the fix-property-equal-panic branch July 31, 2024 15:59
@pwhelan pwhelan mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwhelan pwhelan pwhelan approved these changes

@jasmingacic jasmingacic Awaiting requested review from jasmingacic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasparada @pwhelan