Cannot launch CEF 138 as administrator on Windows

[handerss-spotfire]

After upgrade from 137 to 138 CEF fails to launch as admin. The call to browser_runner_->Initialize in CefUIThread::InitializeBrowserRunner returns the new CEF_RESULT_CODE_NORMAL_EXIT_AUTO_DE_ELEVATED.

In the case of our application where we set a separate BrowserSubprocessPath it tries to re-launch using our main executable instead which fails catastrophically.

In the case of cefclient.exe (from https://cef-builds.spotifycdn.com/cef_binary_138.0.17%2Bgac9b751%2Bchromium-138.0.7204.97_windows64_client.tar.bz2) it seems to simply not launch when attempting to launch it as administrator (no window appears but a cefclient.exe process remains alive).

[handerss-spotfire]

Due to this change in chromium: https://chromium-review.googlesource.com/c/chromium/src/+/6515318

Disabling the AutoDeElevate feature seems to avoid this feature. Append the command line switch --do-not-de-elevate has the same effect.

[magreenblatt]

@handerss-spotfire Does your use case require running as Administrator?

[botder]

We have users running MTA:SA (multiplayer mod for GTA:SA) with Administrator, and this change in Chromium made CEF/Chromium ignore the provided "browser subprocess path" setting, which resulted in CEF trying to launch GTA:SA via gta_sa.exe, which is never going to work for obvious reasons. multitheftauto/mtasa-blue@578f3a2

[handerss-spotfire]

@magreenblatt Yes, in some instances I would assume customer's have to run our application as administrator. We disable the de-elevation feature for now though.

[magreenblatt]

The purpose of this feature (as I understand it) is to relaunch the main executable de-elevated. That seems reasonable, however it also doesn't appear to work with cefclient at M138, and that should be fixed. Applications that cannot relaunch the main executable should in any case run with one of the proposed workarounds.

Disabling the AutoDeElevate feature seems to avoid this feature. Append the command line switch --do-not-de-elevate has the same effect.

[magreenblatt]

doesn't appear to work with cefclient at M138, and that should be fixed

1. Run Terminal as Administrator
2. Run cefclient (tested 138.0.27+g0b28f18+chromium-138.0.7204.158_windows64_client)
3. Process shows in Task Manager but no window is created

Running with --do-not-de-elevate shows the window as expected.

[magreenblatt]

Looks like the application is hanging during exit:

>	base.dll!base::WaitableEvent::TimedWaitImpl(base::TimeDelta wait_delta) Line 99	C++
 	base.dll!base::WaitableEvent::TimedWait(base::TimeDelta wait_delta) Line 68	C++
 	base.dll!base::WaitableEvent::Wait() Line 51	C++
 	base.dll!base::StackSamplingProfiler::~StackSamplingProfiler() Line 911	C++
 	libcef.dll!std::__Cr::default_delete<base::StackSamplingProfiler>::operator()(base::StackSamplingProfiler * __ptr) Line 76	C++
 	libcef.dll!std::__Cr::unique_ptr<base::StackSamplingProfiler,std::__Cr::default_delete<base::StackSamplingProfiler>>::reset(base::StackSamplingProfiler * __p) Line 288	C++
 	libcef.dll!std::__Cr::unique_ptr<base::StackSamplingProfiler,std::__Cr::default_delete<base::StackSamplingProfiler>>::~unique_ptr() Line 256	C++
 	libcef.dll!sampling_profiler::ThreadProfiler::~ThreadProfiler() Line 107	C++
 	libcef.dll!std::__Cr::default_delete<sampling_profiler::ThreadProfiler>::operator()(sampling_profiler::ThreadProfiler * __ptr) Line 76	C++
 	libcef.dll!std::__Cr::unique_ptr<sampling_profiler::ThreadProfiler,std::__Cr::default_delete<sampling_profiler::ThreadProfiler>>::reset(sampling_profiler::ThreadProfiler * __p) Line 288	C++
 	libcef.dll!std::__Cr::unique_ptr<sampling_profiler::ThreadProfiler,std::__Cr::default_delete<sampling_profiler::ThreadProfiler>>::~unique_ptr() Line 256	C++
 	libcef.dll!MainThreadStackSamplingProfiler::~MainThreadStackSamplingProfiler() Line 47	C++
 	libcef.dll!std::__Cr::default_delete<MainThreadStackSamplingProfiler>::operator()(MainThreadStackSamplingProfiler * __ptr) Line 76	C++
 	libcef.dll!std::__Cr::unique_ptr<MainThreadStackSamplingProfiler,std::__Cr::default_delete<MainThreadStackSamplingProfiler>>::reset(MainThreadStackSamplingProfiler * __p) Line 288	C++
 	libcef.dll!std::__Cr::unique_ptr<MainThreadStackSamplingProfiler,std::__Cr::default_delete<MainThreadStackSamplingProfiler>>::~unique_ptr() Line 256	C++
 	libcef.dll!CefMainRunner::~CefMainRunner() Line 27	C++
 	libcef.dll!std::__Cr::default_delete<CefMainRunner>::operator()(CefMainRunner * __ptr) Line 76	C++
 	libcef.dll!std::__Cr::unique_ptr<CefMainRunner,std::__Cr::default_delete<CefMainRunner>>::reset(CefMainRunner * __p) Line 288	C++
 	libcef.dll!std::__Cr::unique_ptr<CefMainRunner,std::__Cr::default_delete<CefMainRunner>>::~unique_ptr() Line 256	C++
 	libcef.dll!CefContext::~CefContext() Line 338	C++
 	libcef.dll!CefInitialize(const CefMainArgs & args, const CefStructBase<CefSettingsTraits> & settings, scoped_refptr<CefApp> application, void * windows_sandbox_info) Line 232	C++

We probably need to delay initialization of CefMainRunner::sampling_profiler_ (so that it isn't initialized if we exit early).

[magreenblatt]

We probably need to delay initialization of CefMainRunner::sampling_profiler_ (so that it isn't initialized if we exit early).

Chrome also initializes this early (in ChromeMainDelegate::CreateThreadPool), so that might not be the exact issue.

[magreenblatt]

We probably need to delay initialization of CefMainRunner::sampling_profiler_ (so that it isn't initialized if we exit early).

StackSamplingProfiler::SamplingThread::ScheduleCollectionStop is being called during shutdown, but SamplingThread::RemoveCollectionTask never executes. The StackSamplingProfiler thread that calls PostTaskAndReply is still running, but the task posted to thread_pool_runner_ never executes.

Chrome normally destroys the StackSamplingProfiler via ChromeContentBrowserClient::ThreadPoolWillTerminate, however this isn't called in the early exit case.

[magreenblatt]

The de-elevate early exit on Windows occurs later during initialization then the process notified early exit. This requires execution of additional shutdown logic for proper shutdown handling.

Call stack for de-elevate early exit:

>	base.dll!base::win::RunDeElevated(const base::CommandLine & command_line) Line 48	C++
 	libcef.dll!ChromeBrowserMainPartsWin::MaybeAutoDeElevate() Line 1114	C++
 	libcef.dll!ChromeBrowserMainPartsWin::PreEarlyInitialization() Line 624	C++
 	content.dll!content::BrowserMainLoop::EarlyInitialization() Line 566	C++
 	content.dll!content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams parameters) Line 115	C++
 	libcef.dll!CefMainRunner::RunMainProcess(content::MainFunctionParams main_function_params) Line 377	C++
 	libcef.dll!ChromeMainDelegateCef::RunProcess(const std::__Cr::basic_string<char,std::__Cr::char_traits<char>,std::__Cr::allocator<char>> & process_type, content::MainFunctionParams main_function_params) Line 487	C++
 	content.dll!content::RunBrowserProcessMain(content::MainFunctionParams main_function_params, content::ContentMainDelegate * delegate) Line 727	C++
 	content.dll!content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams main_params, bool start_minimal_browser) Line 1327	C++
 	content.dll!content::ContentMainRunnerImpl::Run() Line 1182	C++
 	content.dll!content::ContentMainRun(content::ContentMainRunner * content_main_runner) Line 369	C++
 	libcef.dll!CefMainRunner::ContentMainRun(bool * initialized, base::OnceCallback<void ()> context_initialized) Line 319	C++
 	libcef.dll!CefMainRunner::Initialize(CefStructBase<CefSettingsTraits> * settings, scoped_refptr<CefApp> application, const CefMainArgs & args, void * windows_sandbox_info, bool * initialized, base::OnceCallback<void ()> context_initialized) Line 72	C++
 	libcef.dll!CefContext::Initialize(const CefMainArgs & args, const CefStructBase<CefSettingsTraits> & settings, scoped_refptr<CefApp> application, void * windows_sandbox_info) Line 386	C++
 	libcef.dll!CefInitialize(const CefMainArgs & args, const CefStructBase<CefSettingsTraits> & settings, scoped_refptr<CefApp> application, void * windows_sandbox_info) Line 226	C++

Call stack for process notified early exit:

>	libcef.dll!`anonymous namespace'::AcquireProcessSingleton(const base::FilePath & user_data_dir) Line 524	C++
 	libcef.dll!ChromeMainDelegate::PostEarlyInitialization(std::__Cr::variant<content::ContentMainDelegate::InvokedInBrowserProcess,content::ContentMainDelegate::InvokedInChildProcess> invoked_in) Line 770	C++
 	libcef.dll!ChromeMainDelegateCef::PostEarlyInitialization(std::__Cr::variant<content::ContentMainDelegate::InvokedInBrowserProcess,content::ContentMainDelegate::InvokedInChildProcess> invoked_in) Line 463	C++
 	content.dll!content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams main_params, bool start_minimal_browser) Line 1243	C++
 	content.dll!content::ContentMainRunnerImpl::Run() Line 1182	C++
 	content.dll!content::ContentMainRun(content::ContentMainRunner * content_main_runner) Line 369	C++
 	libcef.dll!CefMainRunner::ContentMainRun(bool * initialized, base::OnceCallback<void ()> context_initialized) Line 319	C++
 	libcef.dll!CefMainRunner::Initialize(CefStructBase<CefSettingsTraits> * settings, scoped_refptr<CefApp> application, const CefMainArgs & args, void * windows_sandbox_info, bool * initialized, base::OnceCallback<void ()> context_initialized) Line 72	C++
 	libcef.dll!CefContext::Initialize(const CefMainArgs & args, const CefStructBase<CefSettingsTraits> & settings, scoped_refptr<CefApp> application, void * windows_sandbox_info) Line 386	C++
 	libcef.dll!CefInitialize(const CefMainArgs & args, const CefStructBase<CefSettingsTraits> & settings, scoped_refptr<CefApp> application, void * windows_sandbox_info) Line 226	C++