Skip to content

Add SidebarBottom to toggle sidebar filtering based on story status#45

Merged
ghengeveld merged 8 commits into
mainfrom
ghengeveld/ap-3339-allow-sidebar-filtering
Aug 26, 2023
Merged

Add SidebarBottom to toggle sidebar filtering based on story status#45
ghengeveld merged 8 commits into
mainfrom
ghengeveld/ap-3339-allow-sidebar-filtering

Conversation

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld ghengeveld commented Aug 23, 2023

Fixes AP-3301, AP-3302, AP-3303

Also removes the "pending" story status, because it shows as an ugly "clock" icon and we don't really need to show the "in progress" state of a test in the sidebar.

Note: this depends on a canary version of Storybook and I had to downgrade to React 16 for Storybook compatibility.

Screenshot 2023-08-23 at 16 09 59
📦 Published PR as canary version: 0.0.40--canary.45.460fa88.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.40--canary.45.460fa88.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.40--canary.45.460fa88.0

@linear
Copy link
Copy Markdown

linear Bot commented Aug 23, 2023

@ghengeveld ghengeveld changed the title Add experimental SidebarBottom addon to toggle sidebar filtering based on story status Add SidebarBottom to toggle sidebar filtering based on story status Aug 23, 2023
Copy link
Copy Markdown
Contributor

@weeksling weeksling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Question regarding the new fixed version of storybook, and whether this should wait until that's stable to be merged

Comment thread package.json Outdated
Comment thread package.json
Comment thread src/components/SuffixInput.tsx
Comment thread src/utils/testsToStatusUpdate.ts
@weeksling
Copy link
Copy Markdown
Contributor

@ghengeveld I approved from the look of the code, however testing this I couldn't actually see the filter menu in storybook. Is there anything extra you need to do to enable or, or should switching to this branch, running yarn and running yarn start show the new slot?

Copy link
Copy Markdown
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but we should work out what we are doing with errors. I'm OK with creating a ticket for that and merging as is though.

Comment thread src/SidebarBottom.tsx
@ghengeveld ghengeveld merged commit e319f92 into main Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants