Add SidebarBottom to toggle sidebar filtering based on story status#45
Merged
Merged
Conversation
weeksling
approved these changes
Aug 23, 2023
Contributor
weeksling
left a comment
There was a problem hiding this comment.
lgtm. Question regarding the new fixed version of storybook, and whether this should wait until that's stable to be merged
Contributor
|
@ghengeveld I approved from the look of the code, however testing this I couldn't actually see the filter menu in storybook. Is there anything extra you need to do to enable or, or should switching to this branch, running |
tmeasday
approved these changes
Aug 24, 2023
Member
tmeasday
left a comment
There was a problem hiding this comment.
Code LGTM but we should work out what we are doing with errors. I'm OK with creating a ticket for that and merging as is though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AP-3301, AP-3302, AP-3303
Also removes the "pending" story status, because it shows as an ugly "clock" icon and we don't really need to show the "in progress" state of a test in the sidebar.
Note: this depends on a canary version of Storybook and I had to downgrade to React 16 for Storybook compatibility.
📦 Published PR as canary version:
0.0.40--canary.45.460fa88.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.40--canary.45.460fa88.0 # or yarn add @chromaui/addon-visual-tests@0.0.40--canary.45.460fa88.0