Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN]: remove offset ID atomic from record segment reader #3371

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Dec 30, 2024

Description of changes

Small cleanup to clarify usage of offset ID on reader.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb requested a review from HammadB December 30, 2024 20:07
@codetheweb codetheweb marked this pull request as ready for review December 30, 2024 20:07
@codetheweb codetheweb force-pushed the feat-pipeline-flushing-2 branch from 1e493ab to ad6e0db Compare January 2, 2025 22:07
@codetheweb codetheweb force-pushed the cln-remove-offset-id-atomic-from-reader branch from 54af109 to f3e0ec9 Compare January 2, 2025 22:07
@codetheweb codetheweb force-pushed the feat-pipeline-flushing-2 branch 2 times, most recently from 3b1a65f to a37ca15 Compare January 3, 2025 16:21
@codetheweb codetheweb force-pushed the cln-remove-offset-id-atomic-from-reader branch from f3e0ec9 to 1d2273f Compare January 3, 2025 16:21
@codetheweb codetheweb force-pushed the feat-pipeline-flushing-2 branch from a37ca15 to 8ff398b Compare January 3, 2025 19:24
@codetheweb codetheweb force-pushed the cln-remove-offset-id-atomic-from-reader branch from 1d2273f to 4635765 Compare January 3, 2025 19:34
@codetheweb codetheweb force-pushed the cln-remove-offset-id-atomic-from-reader branch from 4635765 to 1e8291e Compare January 6, 2025 20:40
@codetheweb codetheweb force-pushed the feat-pipeline-flushing-2 branch from 34de5a2 to d165237 Compare January 6, 2025 20:59
@codetheweb codetheweb force-pushed the cln-remove-offset-id-atomic-from-reader branch from 1e8291e to 497d5b1 Compare January 6, 2025 20:59
@codetheweb codetheweb changed the base branch from feat-pipeline-flushing-2 to graphite-base/3371 January 6, 2025 21:47
@codetheweb codetheweb force-pushed the cln-remove-offset-id-atomic-from-reader branch from 497d5b1 to f4d4bcc Compare January 6, 2025 21:47
@codetheweb codetheweb changed the base branch from graphite-base/3371 to main January 6, 2025 21:48
@codetheweb codetheweb force-pushed the cln-remove-offset-id-atomic-from-reader branch from f4d4bcc to 195f7f7 Compare January 6, 2025 21:48
@codetheweb codetheweb merged commit df4fea1 into main Jan 6, 2025
79 checks passed
@codetheweb codetheweb deleted the cln-remove-offset-id-atomic-from-reader branch January 6, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants