[CHORE] enable tracing for our crates #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
sanketkedia
reviewed
Oct 23, 2024
| @@ -39,7 +39,8 @@ pub(crate) fn init_otel_tracing(service_name: &String, otel_endpoint: &String) { | |||
| .with_filter(tracing_subscriber::filter::LevelFilter::INFO); | |||
| // global filter layer. Don't filter anything at global layer for this crate. And disable | |||
There was a problem hiding this comment.
nit: change the comment here as it is not in sync with the code below
rescrv
force-pushed
the
rescrv/qol-tracing
branch
from
2d5e187
to
27c9f5c
Compare
rescrv
force-pushed
the
rescrv/qol-tracing
branch
from
27c9f5c
to
af30d87
Compare
HammadB
reviewed
Oct 24, 2024
| let global_layer = EnvFilter::new( | ||
| "error,".to_string() | ||
| + &vec
There was a problem hiding this comment.
everytime we add a crate, will we have to add it here?
There was a problem hiding this comment.
If we want it to be something other than error, yes. There's no real good way to select by crate and then not have to select by crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
workercrate. Enable it for all our crates at trace level and info level for non-chroma crates.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?