[BUG] Fix NAC getting stuck #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sanketkedia and the rest of your teammates on |
HammadB
approved these changes
Oct 24, 2024
rescrv
reviewed
Oct 24, 2024
| @@ -444,5 +450,7 @@ mod tests { | |||
| test_multipart_get_for_size(1024 * 1024 * 7).await; | |||
| // At > 8 MB. | |||
| test_multipart_get_for_size(1024 * 1024 * 19).await; | |||
| // Greater than NAC limit i.e. > 5*8 MB = 40 MB. | |||
There was a problem hiding this comment.
I think he's saying the NAC limit is 5*8, so this will be greater than that and trigger the bug we found? But I am not sure where 5 comes from
There was a problem hiding this comment.
codetheweb
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Description of changes *Summarize the changes made by this PR.* - NAC would just get stuck if all tokens are exhausted by a single request in a low concurrency setting. There is a bug in the code that defers the release of all tokens for a request to the very end, this PR fixes that. Verified through a local repro. ## Test plan - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None