[TST] Move clippy into the lint job #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
changed the title
codetheweb
approved these changes
Oct 1, 2024
rescrv
approved these changes
Oct 1, 2024
codetheweb
reviewed
Oct 1, 2024
| - name: Cargo fmt check | ||
| shell: bash | ||
| run: cargo fmt -- --check | ||
| - name: Clippy | ||
| run: cargo clippy --all-targets --all-features --keep-going -- -D warnings |
There was a problem hiding this comment.
maybe we should modify the steps in this workflow to always run, even if one errors?
There was a problem hiding this comment.
Good point. Updated so that it continues-on-error for non-setup steps so that if setup fails, the job fails.
itaismith
pushed a commit
that referenced
this pull request
Oct 10, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Moves clippy into its own job so that we don't block tests. It is good to be able to run these separately. - Unifies the rust lint jobs into the lint action, where `cargo fmt` was already running. - New functionality - None ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
cargo fmtwas already running.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None