Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] S3 client not respecting timeout #2643

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Aug 7, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • We only applied the timeouts in the case of Minio credentials. This applies in in both places
    • Some minor code duplication - I am OK with it since its very local.
  • New functionality
    • Non

Test plan

How are these changes tested?
I do not think there is a sensible way to test this against real s3?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@HammadB HammadB marked this pull request as ready for review August 7, 2024 05:21
Copy link

github-actions bot commented Aug 7, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB enabled auto-merge (squash) August 8, 2024 00:12
@HammadB HammadB merged commit e669dbf into main Aug 8, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants