Chrivers/normalization #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrivers
force-pushed
the
chrivers/normalization
branch
2 times, most recently
from
abbe324 to
18c8673
Compare
…otary and Temperature hue resource types
…odels. Use clap_stdin to simplify stdin handling
…wer-case mac address (as seen in real hue dumps)
…covered by model normalizer)
…overed by model normalizer)
…e empty dummy structs
chrivers
force-pushed
the
chrivers/normalization
branch
from
18c8673 to
f3f5c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR integrates a large number of fixes for the Hue Api model.
It is based on testing the API models on real-world data samples provided by volunteers.
Thanks to @hendriksen-mark @tbgoose @AndersTrier @joeblack2k and others for providing sample data for testing.
Also new in this MR is the program
examples/normalize-hue-get.rs, which reads data dumps from hue bridges, and encodes/decodes them through the Bifrost hue api models.Anything that does not come out exactly the same, is reported as an error.
This has helped tremendously in finding weird edge cases in the api models.