Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional group hiding #18

Closed
wants to merge 3 commits into from

Conversation

konistehrad
Copy link

This will affect, but not close, #16. In particular, it looks like the rooms keys in config.yaml get all parsed as lower case, so this will work for groups that are lower case with no spaces. We should evaluate that further. Config is the same as the proposal:

rooms:
  desk_light_isolation:
    name: Desk Light Isolation Group
    hidden: true

@chrivers
Copy link
Owner

This is great! Thanks for your contribution :)

And welcome to the project, if I didn't say so already 👍

I only have some minor comments - reviewing now..

Copy link
Owner

@chrivers chrivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks interesting - there's a must-fix issue, but I'm pretty sure it's not too hard. Let me know if you need help 👍

src/hue/api/room.rs Outdated Show resolved Hide resolved
src/z2m/mod.rs Outdated Show resolved Hide resolved
src/z2m/mod.rs Outdated Show resolved Hide resolved
src/z2m/mod.rs Outdated Show resolved Hide resolved
@konistehrad
Copy link
Author

Great notes, thank you! Updated with requested changes, and happy to be here. 😊

@konistehrad konistehrad requested a review from chrivers August 27, 2024 14:17
@konistehrad konistehrad changed the title Optional hiding Optional group hiding Aug 27, 2024
@konistehrad
Copy link
Author

Per our discussion on discord we're going to try a top-level blacklist section instead

@chrivers
Copy link
Owner

Excellent - good work so far, I'm excited to see the next iteration :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants