Made JS code containing the new engine.getPlayer API in controller_ma…#3
Merged
christophehenry merged 1 commit intoJun 19, 2025
Conversation
…pping_validation_test and controllerscriptenginelegacy_test executable without crash
Swiftb0y
reviewed
Jun 17, 2025
Comment on lines
133
to
+145
| void TearDown() override { | ||
| mixxx::Time::setTestMode(false); | ||
| #ifdef MIXXX_USE_QML | ||
| m_rootItems.clear(); | ||
| #endif | ||
| CoverArtCache::destroy(); | ||
| ControllerScriptEngineBase::registerPlayerManager(nullptr); | ||
| ControllerScriptEngineBase::registerTrackCollectionManager(nullptr); | ||
| } | ||
|
|
||
| ~ControllerScriptEngineLegacyTest() { | ||
| // Reset in the correct order to avoid singleton destruction issues | ||
| m_pSoundManager.reset(); |
There was a problem hiding this comment.
I'm not sure if you can have both TearDown and a dtor in a test. I guess if so teardown gets called first?
Author
There was a problem hiding this comment.
This is the same as in other tests. TearDown() is called by GTest after each test case and if an error happens in TearDown(), GTest will flag the test as fail. I tested this code, it is working!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made JS code containing the new engine.getPlayer API in controller_mapping_validation_test and controllerscriptenginelegacy_test executable without crash
This does not yet implement a test itself, but allows to load tracks into decks as in playermanagertest and makes controller_mapping_validation_test working if QML is not enabled.