Skip to content

Fix typo in class name and Spectre.Console markup escaping issue#828

Merged
christianhelle merged 4 commits into
mainfrom
copilot/fix-bugs-in-codebase
Nov 30, 2025
Merged

Fix typo in class name and Spectre.Console markup escaping issue#828
christianhelle merged 4 commits into
mainfrom
copilot/fix-bugs-in-codebase

Conversation

Copilot AI commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Description:

Fixes several bugs discovered during codebase analysis:

1. Typo in class name: WellKnownNamesspacesWellKnownNamespaces

  • Renamed class and file to fix double 's' typo
  • Renamed internal field to ImportedNamespaces to avoid CS0542 (member name collision)

2. Spectre.Console markup parsing error in CLI help

  • --help was failing with: Error: Could not find color or style 'JsonConverter(typeof(JsonStringEnumConverter))'
  • Description text [JsonConverter(...)] was being parsed as markup
  • Fixed by escaping brackets: [[JsonConverter(...)]]

Example of the Spectre.Console fix:

Before (broken):

[Description("...will not have [JsonConverter(typeof(JsonStringEnumConverter))] attributes")]

After (fixed):

[Description("...will not have [[JsonConverter(typeof(JsonStringEnumConverter))]] attributes")]

Files changed:

  • src/Refitter.Core/WellKnownNamespaces.cs (renamed from WellKnownNamesspaces.cs)
  • src/Refitter.Core/RefitInterfaceGenerator.cs
  • src/Refitter.Core/ParameterExtractor.cs
  • src/Refitter/Settings.cs
Original prompt

Find and resolve bugs and issue in the current code base. Be as thorough as possible


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai

coderabbitai Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits November 28, 2025 13:35
Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix and resolve bugs in the current code base Fix typo in class name and Spectre.Console markup escaping issue Nov 28, 2025
Copilot AI requested a review from christianhelle November 28, 2025 13:55
@christianhelle

Copy link
Copy Markdown
Owner

@copilot keep .NET 10 support as the .NET 10 SDK has been officially released

Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>

Copilot AI commented Nov 30, 2025

Copy link
Copy Markdown
Contributor Author

@copilot keep .NET 10 support as the .NET 10 SDK has been officially released

Restored .NET 10.0 target framework in commit 52d7f65.

@sonarqubecloud

Copy link
Copy Markdown

@christianhelle
christianhelle marked this pull request as ready for review November 30, 2025 10:22
Copilot AI review requested due to automatic review settings November 30, 2025 10:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two bugs discovered during codebase analysis: a typo in a class name and a Spectre.Console markup parsing error in CLI help text.

  • Fixed typo: WellKnownNamesspacesWellKnownNamespaces (removed double 's')
  • Escaped square brackets in Description attribute to prevent Spectre.Console markup parsing error
  • Updated auto-generated test files with newer NSwag toolchain version (14.6.2.0 → 14.6.3.0)

Reviewed changes

Copilot reviewed 4 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Refitter/Settings.cs Fixed Spectre.Console markup escaping by changing [JsonConverter(...)] to [[JsonConverter(...)]] in the Description attribute
src/Refitter.Core/WellKnownNamespaces.cs Fixed typo in class name (WellKnownNamesspaces → WellKnownNamespaces) and renamed internal field to ImportedNamespaces to avoid CS0542 naming collision
src/Refitter.Core/RefitInterfaceGenerator.cs Updated references from WellKnownNamesspaces to WellKnownNamespaces
src/Refitter.Core/ParameterExtractor.cs Updated references from WellKnownNamesspaces to WellKnownNamespaces
src/Refitter.SourceGenerator.Tests/AdditionalFiles/Generated/*.g.cs Updated auto-generated test files with newer NSwag toolchain version references (14.6.2.0 → 14.6.3.0)

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@codecov

codecov Bot commented Nov 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (db4b4c0) to head (52d7f65).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          23       23           
  Lines        1938     1938           
  Branches      319      319           
=======================================
  Hits         1844     1844           
  Misses         48       48           
  Partials       46       46           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christianhelle
christianhelle merged commit 4ad957d into main Nov 30, 2025
22 checks passed
@christianhelle
christianhelle deleted the copilot/fix-bugs-in-codebase branch November 30, 2025 11:30
hwinther pushed a commit to hwinther/test that referenced this pull request Dec 18, 2025
Updated [refitter](https://github.com/christianhelle/refitter) from
1.7.0 to 1.7.1.

<details>
<summary>Release notes</summary>

_Sourced from [refitter's
releases](https://github.com/christianhelle/refitter/releases)._

## 1.7.1

### Implemented enhancements

- Improved handling of optional parameters
[\#​448](christianhelle/refitter#448) by
@​christianhelle
- Allow omitting certain operation headers \#​840
[\#​841](christianhelle/refitter#841) by
@​kmc059000
- Migrate unit tests from xUnit to TUnit
[\#​830](christianhelle/refitter#830) by
@​christianhelle
- Refit v9.0.2
[\#​829](christianhelle/refitter#829)
- Add .NET 10 support
[\#​822](christianhelle/refitter#822)
([christianhelle](https://github.com/christianhelle))
- Fix missing XML doc for CancellationToken
[\#​819](christianhelle/refitter#819) by
@​christianhelle
- Fix incorrect casing on multi-part form data parameters
[\#​806](christianhelle/refitter#806) by
@​christianhelle
- Optional parameters with default values
[\#​803](christianhelle/refitter#803) by
@​christianhelle
- Asana API specs strange naming
[\#​364](christianhelle/refitter#364) by
@​christianhelle

### Fixed bugs

- Using cancellation tokens with xml doc comments plus
TreatWarningsAsErrors and documentation file
[\#​817](christianhelle/refitter#817)
- Multipart form data parameters wrong casing
[\#​805](christianhelle/refitter#805)
- Use of non generic `JsonStringEnumConverter` prohibits usage of
Json-SourceGenerationContext
[\#​778](christianhelle/refitter#778)
- SourceGenerator 1.5 and newer causes build error with Visual Studio
2022 [\#​627](christianhelle/refitter#627)
- Fix string escaping, null safety, and numeric literals in optional
parameter default values
[\#​804](christianhelle/refitter#804)
- Fix typo in class name and Spectre.Console markup escaping issue
[\#​828](christianhelle/refitter#828)

### Merged pull requests

- docs: add kmc059000 as a contributor for ideas, and code
[\#​842](christianhelle/refitter#842)
([allcontributors[bot]](https://github.com/apps/allcontributors))
- Bump actions/upload-artifact from 5 to 6
[\#​838](christianhelle/refitter#838)
([dependabot[bot]](https://github.com/apps/dependabot))
- Update dependency TUnit to 1.5.37
[\#​836](christianhelle/refitter#836)
([renovate[bot]](https://github.com/apps/renovate))
- Update dotnet monorepo
[\#​834](christianhelle/refitter#834)
([renovate[bot]](https://github.com/apps/renovate))
- Update dependency TUnit to 1.5.6
[\#​833](christianhelle/refitter#833)
([renovate[bot]](https://github.com/apps/renovate))
- Update dependency TUnit to 1.5.0
[\#​832](christianhelle/refitter#832)
([renovate[bot]](https://github.com/apps/renovate))
- chore\(deps\): update dependency spectre.console.cli to 0.53.1
[\#​827](christianhelle/refitter#827)
([renovate[bot]](https://github.com/apps/renovate))
- chore\(deps\): update dependency polly to 8.6.5
[\#​826](christianhelle/refitter#826)
([renovate[bot]](https://github.com/apps/renovate))
- Bump actions/checkout from 5 to 6
[\#​825](christianhelle/refitter#825)
([dependabot[bot]](https://github.com/apps/dependabot))
- chore\(deps\): update nswag monorepo to 14.6.3
[\#​824](christianhelle/refitter#824)
([renovate[bot]](https://github.com/apps/renovate))
- chore\(deps\): update dependency microsoft.build.utilities.core to v18
[\#​821](christianhelle/refitter#821)
([renovate[bot]](https://github.com/apps/renovate))
- chore\(deps\): update dependency swashbuckle.aspnetcore to 10.0.1
[\#​820](christianhelle/refitter#820)
([renovate[bot]](https://github.com/apps/renovate))
- docs: add karoberts as a contributor for bug
[\#​818](christianhelle/refitter#818)
([allcontributors[bot]](https://github.com/apps/allcontributors))
- chore\(deps\): update dependency swashbuckle.aspnetcore to v10
[\#​816](christianhelle/refitter#816)
([renovate[bot]](https://github.com/apps/renovate))
- chore\(deps\): update dependency microsoft.extensions.http.resilience
to v10 [\#​815](christianhelle/refitter#815)
([renovate[bot]](https://github.com/apps/renovate))
- Update Spectre.Console.Cli to 0.53.0
[\#​814](christianhelle/refitter#814)
([Copilot](https://github.com/apps/copilot-swe-agent))
- chore\(deps\): update dotnet monorepo to v10 \(major\)
[\#​813](christianhelle/refitter#813)
([renovate[bot]](https://github.com/apps/renovate))
- chore\(deps\): update dependency microsoft.net.test.sdk to 18.0.1
[\#​808](christianhelle/refitter#808)
([renovate[bot]](https://github.com/apps/renovate))
- docs: add mhartmair-cubido as a contributor for bug
[\#​807](christianhelle/refitter#807)
([allcontributors[bot]](https://github.com/apps/allcontributors))

### New Contributors
* @​kmc059000 made their first contribution in
christianhelle/refitter#841

Full Changelog:
christianhelle/refitter@1.7.0...1.7.1

Commits viewable in [compare
view](christianhelle/refitter@1.7.0...1.7.1).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=refitter&package-manager=nuget&previous-version=1.7.0&new-version=1.7.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants