Skip to content

NSwag v14.6.1#795

Closed
christianhelle wants to merge 4 commits into
mainfrom
nswag-14.6.1
Closed

NSwag v14.6.1#795
christianhelle wants to merge 4 commits into
mainfrom
nswag-14.6.1

Conversation

@christianhelle

@christianhelle christianhelle commented Oct 21, 2025

Copy link
Copy Markdown
Owner

This pull request updates several project dependencies and adds a new package to the test projects. The main changes are version bumps for the NSwag.CodeGeneration.CSharp and NSwag.Core.Yaml packages across multiple projects, and the inclusion of System.Text.Json in the test projects to support JSON serialization and deserialization in tests.

Dependency Updates:

  • Upgraded NSwag.CodeGeneration.CSharp and NSwag.Core.Yaml from version 14.6.0 to 14.6.1 in Refitter.Core.csproj and Refitter.SourceGenerator.csproj to ensure compatibility with the latest features and bug fixes. [1] [2]

Test Project Enhancements:

  • Added System.Text.Json version 9.0.10 as a dependency to Refitter.SourceGenerator.Tests.csproj and Refitter.Tests.csproj to enable JSON handling in unit tests. [1] [2]

Summary by CodeRabbit

  • Chores
    • Updated NSwag code generation packages to version 14.6.1.
    • Added System.Text.Json dependency (version 9.0.9) to test projects for improved compatibility.

@christianhelle christianhelle self-assigned this Oct 21, 2025
Copilot AI review requested due to automatic review settings October 21, 2025 20:05
@christianhelle christianhelle added enhancement New feature, bug fix, or request dependencies Pull requests that update a dependency file labels Oct 21, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the NSwag packages to version 14.6.1 and adds System.Text.Json as an explicit dependency to the test projects. The changes ensure the project uses the latest NSwag features and bug fixes while enabling proper JSON handling capabilities in unit tests.

Key changes:

  • Upgraded NSwag.CodeGeneration.CSharp and NSwag.Core.Yaml from 14.6.0 to 14.6.1
  • Added System.Text.Json 9.0.10 to test projects to support JSON serialization/deserialization in tests

Reviewed Changes

Copilot reviewed 4 out of 10 changed files in this pull request and generated no comments.

File Description
src/Refitter.Core/Refitter.Core.csproj Updated NSwag packages to version 14.6.1 in the core library
src/Refitter.SourceGenerator/Refitter.SourceGenerator.csproj Updated NSwag packages to version 14.6.1 in the source generator
src/Refitter.Tests/Refitter.Tests.csproj Added System.Text.Json 9.0.10 package reference
src/Refitter.SourceGenerator.Tests/Refitter.SourceGenerator.Tests.csproj Added System.Text.Json 9.0.10 package reference

@coderabbitai

coderabbitai Bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Bumped NSwag packages from 14.6.0 to 14.6.1 in core and source-generator projects; added PackageReference to System.Text.Json 9.0.9 in two test projects. No code or public API changes present.

Changes

Cohort / File(s) Summary
NSwag package version bump
src/Refitter.Core/Refitter.Core.csproj, src/Refitter.SourceGenerator/Refitter.SourceGenerator.csproj
Upgraded NSwag.CodeGeneration.CSharp and NSwag.Core.Yaml from 14.6.0 to 14.6.1.
System.Text.Json addition (tests)
src/Refitter.SourceGenerator.Tests/Refitter.SourceGenerator.Tests.csproj, src/Refitter.Tests/Refitter.Tests.csproj
Added System.Text.Json PackageReference version 9.0.9 to test project files.

Sequence Diagram(s)

(omitted — changes are package/version updates only, no control-flow modifications)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰
I nudged the versions, soft and neat,
Two NSwag hops and JSON for the test suite.
No lines rewritten, just packages cheered,
A tiny update — the burrow is cleared. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "NSwag v14.6.1" directly corresponds to the primary objective of the pull request, which is to upgrade NSwag.CodeGeneration.CSharp and NSwag.Core.Yaml from version 14.6.0 to 14.6.1 across multiple project files. The title is concise, specific, and clearly communicates the main change without vague terminology. While the PR also adds System.Text.Json v9.0.9 to test projects, these are supporting changes that enable testing of the NSwag upgrade, not the primary objective. The title appropriately focuses on the main change and is suitable for commit history scanning.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nswag-14.6.1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d346ed9 and 0204d0d.

📒 Files selected for processing (2)
  • src/Refitter.SourceGenerator.Tests/Refitter.SourceGenerator.Tests.csproj (1 hunks)
  • src/Refitter.Tests/Refitter.Tests.csproj (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/Refitter.SourceGenerator.Tests/Refitter.SourceGenerator.Tests.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: 👌 Verify build
  • GitHub Check: 👌 Verify build
  • GitHub Check: 👌 Verify build
  • GitHub Check: Analyze (csharp)
🔇 Additional comments (1)
src/Refitter.Tests/Refitter.Tests.csproj (1)

19-19: Update System.Text.Json to version 9.0.10 in both test projects.

The PR objectives specify v9.0.10, but the code implements v9.0.9. The latest stable version 9.0.10 was released on Oct 14, 2025. Update both src/Refitter.Tests/Refitter.Tests.csproj and src/Refitter.SourceGenerator.Tests/Refitter.SourceGenerator.Tests.csproj to use Version="9.0.10" instead of Version="9.0.9".

⛔ Skipped due to learnings
Learnt from: CR
PR: christianhelle/refitter#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-20T20:29:54.111Z
Learning: Multi-targeting: test .NET 8.0 and 9.0 when making framework-specific changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@christianhelle
christianhelle deleted the nswag-14.6.1 branch November 6, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature, bug fix, or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants