-
-
Notifications
You must be signed in to change notification settings - Fork 64
Fix Multipart file array support #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
f6634e4
Update FindSupportedType method to handle collections of FileParamete…
christianhelle 4c90aae
Add MultiPartFormDataArrayTests to validate multipart file uploads
christianhelle 9d48542
Update MultiPartFormDataArrayTests to ensure generated code does not …
christianhelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
src/Refitter.Tests/Examples/MultiPartFormDataArrayTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| using FluentAssertions; | ||
| using Refitter.Core; | ||
| using Refitter.Tests.Build; | ||
| using Refitter.Tests.TestUtilities; | ||
| using Xunit; | ||
|
|
||
| namespace Refitter.Tests.Examples; | ||
|
|
||
| public class MultiPartFormDataArrayTests | ||
| { | ||
| private const string OpenApiSpec = @" | ||
| { | ||
| ""openapi"": ""3.0.2"", | ||
| ""paths"": { | ||
| ""/foo/{id}/files"": { | ||
| ""post"": { | ||
| ""summary"": ""uploads multiple files"", | ||
| ""operationId"": ""uploadFiles"", | ||
| ""parameters"": [ | ||
| { | ||
| ""name"": ""id"", | ||
| ""in"": ""path"", | ||
| ""description"": ""Id of the foo resource"", | ||
| ""required"": true, | ||
| ""schema"": { | ||
| ""type"": ""integer"", | ||
| ""format"": ""int64"" | ||
| } | ||
| } | ||
| ], | ||
| ""requestBody"": { | ||
| ""content"": { | ||
| ""multipart/form-data"": { | ||
| ""schema"": { | ||
| ""type"": ""object"", | ||
| ""properties"": { | ||
| ""files"": { | ||
| ""type"": ""array"", | ||
| ""items"": { | ||
| ""type"": ""string"", | ||
| ""format"": ""binary"" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| ""responses"": { | ||
| ""200"": { | ||
| ""description"": ""successful operation"" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| "; | ||
|
|
||
| [Fact] | ||
| public async Task Can_Generate_Code() | ||
| { | ||
| string generatedCode = await GenerateCode(); | ||
| generatedCode.Should().NotBeNullOrWhiteSpace(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task Can_Build_Generated_Code() | ||
| { | ||
| string generatedCode = await GenerateCode(); | ||
| BuildHelper | ||
| .BuildCSharp(generatedCode) | ||
| .Should() | ||
| .BeTrue(); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task Generated_Code_Contains_MultiPart_Attribute() | ||
| { | ||
| string generatedCode = await GenerateCode(); | ||
| generatedCode.Should().Contain("[Multipart]"); | ||
| generatedCode.Should().NotContain("Content-Type: multipart/form-data"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task Generated_Code_Uses_IEnumerable_StreamPart_For_File_Array() | ||
| { | ||
| string generatedCode = await GenerateCode(); | ||
| generatedCode.Should().Contain("long id, IEnumerable<StreamPart> files"); | ||
|
christianhelle marked this conversation as resolved.
|
||
| generatedCode.Should().NotContain("IEnumerable<FileParameter> files"); | ||
| } | ||
|
|
||
| private static async Task<string> GenerateCode() | ||
| { | ||
| var swaggerFile = await SwaggerFileHelper.CreateSwaggerFile(OpenApiSpec); | ||
| var settings = new RefitGeneratorSettings { OpenApiPath = swaggerFile }; | ||
|
|
||
| var sut = await RefitGenerator.CreateAsync(settings); | ||
| var generatedCode = sut.Generate(); | ||
| return generatedCode; | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.