Skip to content

chore: add ability to skip-validation + simplify unicode logging #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianhelle merged 2 commits into from
Sep 28, 2025
Merged

chore: add ability to skip-validation + simplify unicode logging #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df07553
chore: add ability to skip-validation + simplify unicode logging
david-pw Sep 25, 2025
249d2bf
chore: wrap args path variables with quotes
david-pw Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Refitter.MSBuild/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ Refitter is available as custom MSBuild tasks that includes the Refitter CLI exe
The MSBuild package includes a custom `.target` file which executes the `RefitterGenerateTask` custom task and looks something like this:

```xml
<UsingTask TaskName="RefitterGenerateTask"
AssemblyFile="$(MSBuildThisFileDirectory)Refitter.MSBuild.dll"
<UsingTask TaskName="RefitterGenerateTask"
AssemblyFile="$(MSBuildThisFileDirectory)Refitter.MSBuild.dll"
Condition="Exists('$(MSBuildThisFileDirectory)Refitter.MSBuild.dll')" />
<Target Name="RefitterGenerate" BeforeTargets="BeforeCompile">
<RefitterGenerateTask ProjectFileDirectory="$(MSBuildProjectDirectory)"
DisableLogging="$(RefitterNoLogging)">
DisableLogging="$(RefitterNoLogging)"
SkipValidation="$(RefitterSkipValidation)">
<Output TaskParameter="GeneratedFiles" ItemName="RefitterGeneratedFiles" />
</RefitterGenerateTask>
<ItemGroup>
Expand Down
7 changes: 4 additions & 3 deletions src/Refitter.MSBuild/Refitter.MSBuild.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<Project>

<UsingTask TaskName="RefitterGenerateTask"
AssemblyFile="$(MSBuildThisFileDirectory)Refitter.MSBuild.dll"
<UsingTask TaskName="RefitterGenerateTask"
AssemblyFile="$(MSBuildThisFileDirectory)Refitter.MSBuild.dll"
Condition="Exists('$(MSBuildThisFileDirectory)Refitter.MSBuild.dll')" />

<Target Name="RefitterGenerate" BeforeTargets="CoreCompile">
<RefitterGenerateTask ProjectFileDirectory="$(MSBuildProjectDirectory)"
DisableLogging="$(RefitterNoLogging)">
DisableLogging="$(RefitterNoLogging)"
SkipValidation="$(RefitterSkipValidation)">
<Output TaskParameter="GeneratedFiles" ItemName="RefitterGeneratedFiles" />
</RefitterGenerateTask>
<ItemGroup>
Expand Down
8 changes: 7 additions & 1 deletion src/Refitter.MSBuild/RefitterGenerateTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ public class RefitterGenerateTask : MSBuildTask

public bool DisableLogging { get; set; }

public bool SkipValidation { get; set; }

[Output]
public ITaskItem[] GeneratedFiles { get; set; }

Expand Down Expand Up @@ -78,11 +80,15 @@ private List<string> StartProcess(string file)
TryLogCommandLine("Using .NET 8 version of Refitter.");
}

var args = $"{refitterDll} --settings-file {file}";
var args = $"\"{refitterDll}\" --settings-file \"{file}\" --simple-output";
if (DisableLogging)
{
args += " --no-logging";
}
if (SkipValidation)
{
args += " --skip-validation";
}

TryLogCommandLine($"Starting dotnet {args}");

Expand Down
Loading