Skip to content

Remove reflection-based non-public method testing #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianhelle merged 7 commits into from
Jun 21, 2026
Merged

Remove reflection-based non-public method testing #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8079bed
refactor: remove reflection-based IsValueType tests from CustomCSharp…
christianhelle Jun 21, 2026
12a02f1
refactor: remove reflection-based MergeIfMissingOrThrowOnConflict tests
christianhelle Jun 21, 2026
ba12695
refactor: remove reflection-based FormParameterExtractorTests
christianhelle Jun 21, 2026
070ced6
refactor: remove reflection-dependent tests from ParameterExtractorPr…
christianhelle Jun 21, 2026
8610546
refactor: replace reflection-based parameter fallback test with integ…
christianhelle Jun 21, 2026
fdafe69
fix: correct assertions in integration test for unsanitized parameter…
christianhelle Jun 21, 2026
5d9fbbb
fix: apply CodeRabbit auto-fixes
coderabbitai[bot] Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 0 additions & 118 deletions src/Refitter.Tests/CustomCSharpTypeResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using System.Reflection;
using FluentAssertions;
using NJsonSchema;
using NJsonSchema.CodeGeneration.CSharp;
Expand Down Expand Up @@ -267,121 +266,4 @@ public void Resolve_Nullable_With_Multiple_Mappings_Returns_Correct_Nullable_Typ
resolver.Resolve(new JsonSchema { Format = "uuid" }, true, null).Should().Be("Guid?");
}

[Test]
[Arguments("System.Guid")]
[Arguments("System.DateTime")]
[Arguments("System.DateTimeOffset")]
[Arguments("System.TimeSpan")]
[Arguments("System.Decimal")]
[Arguments("System.Int32")]
[Arguments("System.Int64")]
[Arguments("System.Double")]
[Arguments("System.Single")]
[Arguments("System.Boolean")]
[Arguments("System.Byte")]
[Arguments("System.SByte")]
[Arguments("System.Int16")]
[Arguments("System.UInt16")]
[Arguments("System.UInt32")]
[Arguments("System.UInt64")]
[Arguments("System.Char")]
[Arguments("Guid")]
[Arguments("DateTime")]
[Arguments("DateTimeOffset")]
[Arguments("TimeSpan")]
[Arguments("Decimal")]
[Arguments("Int32")]
[Arguments("Int64")]
[Arguments("Double")]
[Arguments("Single")]
[Arguments("Boolean")]
[Arguments("Byte")]
[Arguments("SByte")]
[Arguments("Int16")]
[Arguments("UInt16")]
[Arguments("UInt32")]
[Arguments("UInt64")]
[Arguments("Char")]
[Arguments("bool")]
[Arguments("byte")]
[Arguments("sbyte")]
[Arguments("char")]
[Arguments("decimal")]
[Arguments("double")]
[Arguments("float")]
[Arguments("int")]
[Arguments("uint")]
[Arguments("long")]
[Arguments("ulong")]
[Arguments("short")]
[Arguments("ushort")]
public void IsValueType_Returns_True_For_All_Known_Mappings(string mappedType)
{
var method = typeof(CustomCSharpTypeResolver).GetMethod(
"IsValueType",
BindingFlags.NonPublic | BindingFlags.Static);

var result = (bool?)method?.Invoke(null, [mappedType]);

result.Should().BeTrue();
}

[Test]
[Arguments("string")]
[Arguments("List<int>")]
[Arguments("System.String")]
[Arguments("System.GuidValue")]
[Arguments("System.DateTimer")]
[Arguments("System.DateTimeOffsets")]
[Arguments("System.TimeSpans")]
[Arguments("System.Decimals")]
[Arguments("System.Int33")]
[Arguments("System.Int128")]
[Arguments("System.DoubleValue")]
[Arguments("System.SingleValue")]
[Arguments("System.BooleanValue")]
[Arguments("System.Bytes")]
[Arguments("System.SBytes")]
[Arguments("System.Int24")]
[Arguments("System.UInt24")]
[Arguments("System.UInt128")]
[Arguments("System.Chars")]
[Arguments("GuidValue")]
[Arguments("DateTimer")]
[Arguments("DateTimeOffsets")]
[Arguments("TimeSpans")]
[Arguments("Decimals")]
[Arguments("Int33")]
[Arguments("Int128")]
[Arguments("DoubleValue")]
[Arguments("SingleValue")]
[Arguments("BooleanValue")]
[Arguments("Bytes")]
[Arguments("SBytes")]
[Arguments("Int24")]
[Arguments("UInt24")]
[Arguments("UInt128")]
[Arguments("Chars")]
[Arguments("boolean")]
[Arguments("bytes")]
[Arguments("sbytes")]
[Arguments("character")]
[Arguments("decimals")]
[Arguments("doubleValue")]
[Arguments("floating")]
[Arguments("integer")]
[Arguments("unsigned")]
[Arguments("longValue")]
[Arguments("ulongValue")]
[Arguments("shortValue")]
public void IsValueType_Returns_False_For_Reference_Types(string mappedType)
{
var method = typeof(CustomCSharpTypeResolver).GetMethod(
"IsValueType",
BindingFlags.NonPublic | BindingFlags.Static);

var result = (bool?)method?.Invoke(null, [mappedType]);

result.Should().BeFalse();
}
}
251 changes: 0 additions & 251 deletions src/Refitter.Tests/FormParameterExtractorTests.cs
View file
Open in desktop

This file was deleted.

Loading
Loading