Skip to content

Inline FileWriter and WellKnownNamespaces utility modules#1130

Merged
christianhelle merged 1 commit into
mainfrom
refactor-utility-modules
Jun 13, 2026
Merged

Inline FileWriter and WellKnownNamespaces utility modules#1130
christianhelle merged 1 commit into
mainfrom
refactor-utility-modules

Conversation

@christianhelle

@christianhelle christianhelle commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Closes #1119

FileWriter (22 lines) was a pass-through that created directories and wrote
files. Inlined directly into GenerationOrchestrator.WriteSingleFile and
WriteMultipleFiles. Removed FileWriter.cs and FileWriterTests.cs.

WellKnownNamespaces (16 lines) was a pass-through that stripped
System.Collections.Generic. prefix. Inlined as a private static method
into InterfaceGenerator (3 call sites) and ParameterShared (2 call sites).
Removed WellKnownNamespaces.cs.

…spaces

FileWriter (22 lines) was a pass-through that created directories and wrote
files. Inlined directly into GenerationOrchestrator.WriteSingleFile and
WriteMultipleFiles. Removed FileWriter.cs and FileWriterTests.cs.

WellKnownNamespaces (16 lines) was a pass-through that stripped
System.Collections.Generic. prefix. Inlined as a private static method
into InterfaceGenerator (3 call sites) and ParameterShared (2 call sites).
Removed WellKnownNamespaces.cs.

Part of Candidate 6 of issue #1118 architecture deepening initiative.
@christianhelle christianhelle self-assigned this Jun 13, 2026
@christianhelle christianhelle added the .NET Pull requests that contain changes to .NET code label Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@christianhelle, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 25 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 624c6f42-499c-43e7-977d-662c5b5f3271

📥 Commits

Reviewing files that changed from the base of the PR and between 1804a6b and 304881e.

📒 Files selected for processing (6)
  • src/Refitter.Core/InterfaceGenerator.cs
  • src/Refitter.Core/ParameterShared.cs
  • src/Refitter.Core/WellKnownNamespaces.cs
  • src/Refitter.Tests/FileWriterTests.cs
  • src/Refitter/FileWriter.cs
  • src/Refitter/GenerationOrchestrator.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor-utility-modules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.98%. Comparing base (865f5f8) to head (304881e).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   83.98%   85.98%   +2.00%     
==========================================
  Files          40       39       -1     
  Lines        2628     2655      +27     
==========================================
+ Hits         2207     2283      +76     
+ Misses        323      271      -52     
- Partials       98      101       +3     
Flag Coverage Δ
unittests 85.98% <100.00%> (+2.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christianhelle
christianhelle merged commit bb9078f into main Jun 13, 2026
14 checks passed
@christianhelle
christianhelle deleted the refactor-utility-modules branch June 13, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Pull requests that contain changes to .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline shallow utility modules: CustomCSharpClientGenerator, FileWriter, Serializer, etc.

1 participant