Skip to content

fix: CodeRabbit auto-fixes for PR #1095 #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coderabbitai wants to merge 1 commit into from
Closed

fix: CodeRabbit auto-fixes for PR #1095 #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Refitter.Core/RefitterSettingsLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ public static class RefitterSettingsLoader
public static RefitGeneratorSettings Load(string json, string baseDirectory)
{
var settings = Serializer.Deserialize<RefitGeneratorSettings>(json);
if (settings is null)
{
throw new System.Text.Json.JsonException("Failed to deserialize settings: result was null");
}
ResolveRelativeSpecPaths(settings, baseDirectory);
return settings;
}
Expand All @@ -49,6 +53,8 @@ public static void ResolveRelativeSpecPaths(RefitGeneratorSettings settings, str
for (var i = 0; i < settings.OpenApiPaths.Length; i++)
{
var path = settings.OpenApiPaths[i];
if (string.IsNullOrWhiteSpace(path))
continue;
if (!IsUrl(path) && !Path.IsPathRooted(path))
{
settings.OpenApiPaths[i] = Path.GetFullPath(Path.Combine(baseDirectory, path));
Expand Down
13 changes: 7 additions & 6 deletions src/Refitter/GenerateCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,15 @@ protected override async Task<int> ExecuteAsync(CommandContext context, Settings
version += " (local build)";

// Header with branding
_reporter.ReportHeader(version);
if (!settings.NoBanner)
_reporter.ReportHeader(version);

// Support information
var supportKey = settings.NoLogging
? "Unavailable when logging is disabled"
: SupportInformation.GetSupportKey();

_reporter.ReportSupportKey(supportKey);
if (!settings.NoLogging)
{
var supportKey = SupportInformation.GetSupportKey();
_reporter.ReportSupportKey(supportKey);
}

if (context.Arguments.Any(a => a.Equals("--version", StringComparison.OrdinalIgnoreCase)) ||
context.Arguments.Any(a => a.Equals("-v", StringComparison.OrdinalIgnoreCase)))
Expand Down
Loading