Fix typo in ENDPOINT_URL_ADDRESS variable #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have utilized the script on Windows, and I wasn't able to get s3cmd to work, but s4cmd worked nicely. I had to modify several places in the script to make it work. I don't believe the script is assumed to be used on windows and I am not good at bash, so I won't propose all fixes, but this PR contains a universal fix.
In addition to the typo fix s4cmd seems to require a slash in the URL as I got from bloomreach/s4cmd#93 (comment)