Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version #162

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix version #162

wants to merge 2 commits into from

Conversation

ajb
Copy link
Collaborator

@ajb ajb commented Dec 25, 2014

  • Use a constant Sync::VERSION for versioning
  • Bump to 0.3.2 because that's the version on RubyGems... although I can't explain why.

@ajb
Copy link
Collaborator Author

ajb commented Dec 25, 2014

Fails because Sync is already a class in Ruby's stdlib: http://ruby-doc.org/stdlib-1.9.3/libdoc/sync/rdoc/Sync_m.html

@chrismccord
Copy link
Owner

Fails because Sync is already a class in Ruby's stdlib

Hmm. That's a problem. I don't think we have namespace clashes elsewhere, but not sure what the best route from here is. I think for now we could just move the constant to another namespace.

@ajb
Copy link
Collaborator Author

ajb commented Dec 30, 2014

Man. Changing our module's name would be pretty crappy too. If the only thing it's stopping us from doing is having our VERSION constant, then I'm fine punting on it for now.

@chrismccord
Copy link
Owner

If the only thing it's stopping us from doing is having our VERSION constant, then I'm fine punting on it for now.

Clashing namespaces in the stdlib is really not ideal, but I agree this is the best for now.

@ajb
Copy link
Collaborator Author

ajb commented Feb 6, 2016

This finally comes around to bite us: rubygems/rubygems.org#1156 (comment)

@ajb ajb modified the milestone: 1.0 Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants