feat: Collapsable ProfitLoss header #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rando128
changed the title
|
Yap, ok. Looks good, as usual. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small UX improvement that makes the Closed Trades and Opened Trades accordions collapsable (same behaviour than the Account Balance accordion). On mobile, these accordions are collapsed by default.
The tooltip text of the Closed Trades header that was missing has been added.
This PR only impacts only
public/js/ProfitLossWrapper.jsfile.Motivation and Context
On mobile when you are trading multiple asset bases (USDT, ETH, BTC, BUSD...), these headers tend to be quite long forcing the user to scroll couple of times before reaching the symbol section.
How Has This Been Tested?
This is working on my production setup.
Screenshots (if appropriate):