-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search and filtering UX improvements #591
feat: search and filtering UX improvements #591
Conversation
…rch-and-filtering-experience
@chrisleekr, I saw you assigned the ticket to me. What do you want me to do? |
@rando128 don't worry. I just assigned you because it was opened by you. I am writing test cases for your changes. The only feedback is I didn't realise I could click "Open buy orders" or "Open trades" until I saw the code. |
@rando128 To be honest, I am not sure. Haha. I am not good at UX. Hence, I researched some other cases. In any way, probably don't worry too much about it. I will merge in, and we can improve later on. |
@rando128 |
Thx. I'll address the UX improvement in another PR. Sorry for leaking a |
Description
This PR brings some usability enhancements for searching and filtering the dashboard symbols.
4 main capabilities have been added:
open trades
in the order stats sectionopen orders - buy
in the order stats sectionA toast has been added to inform which symbols are shown in the dashboard and the filtering icon of the header shows the red dot only when disabled symbols are hidden.
Changes:
common.js
.OrderStats
class includes the logic for displaying the current filter and making open trades/orders sections clickable (if their value is not 0)AccountWrapper.js
andAccountWrapperAsset.js
classes have been updated to include a search button in the account balance sectionsetSearchKeyword
function ofApp.js
now handles toastsFilterIcon.js
has been updated to propagate the searchKeyword changes only when the form is submittedapp.css
has been extended for button handling in the order stats sectionCaveats:
saveNumberOfBuyOpenOrders
calculation doesn't always get all the symbols with active trades. This is something I discovered while developing this PR. I will open a separate bug as I couldn't find a straightforward reason.Motivation and Context
I often struggle to find myself scrolling and changing paginations and search to get the relevant symbols. These improvements will hopefully make the experience smoother.
How Has This Been Tested?
This is working on my production server
Screenshots (if appropriate):
Filtering from Account balance
Active filter with informative toast
SearchKeyword filtering
Open trades filtering
Open orders filtering
Only with hidden disabled symbols