fix: cancel orders when current price is over order price #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cancel order when current price is over order price.
Related Issue
#566
Motivation and Context
Sometimes the market is very volatile which can cause while buy order is put the price will raise so much the buy order is not executed and stay there until price is dropped again. This is bad because sell order can't be processed while buy order is active and you can miss opportunity to sell.
Same thing with sell order when market drop rapidly and sell order is not executed then you can miss opportunity to buy low or even to trigger stop-loss because you can't sell when anothern sell order is active.
How Has This Been Tested?
Test provided in tests.
Screenshots (if appropriate):