Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api error page #556

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Conversation

habibalkhabbaz
Copy link
Contributor

@habibalkhabbaz habibalkhabbaz commented Dec 20, 2022

Description

Before this PR, if we click on the 🔒 icon on the top right of the screen, the API error page will be shown instead of the lock screen even If I have the correct API credentials.

To solve this, I only give the condition of the lock screen more priority than the API error page.
The rest changes only for linting.

Related Issue

Not applicable.

Motivation and Context

How Has This Been Tested?

Manually clicking on the 🔒 icon will redirect you to the lock screen instead of the condition of API error page

Screenshots (if appropriate):

Not applicable.

@chrisleekr
Copy link
Owner

@habibalkhabbaz
Ah, good point!!! 👍

@chrisleekr chrisleekr merged commit 8ed5fcc into chrisleekr:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants