fix: give redlock enough time for locking #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
redlockdoes not have enough time to unlock after doing the requested operation.What I mean is that if the
redlocklocks a key for500msand it is expired before callinglock.unlock(), and then callinglock.unlock()will throw an exception like:Because the lock already expired and unlock cannot be done on an expired lock.
Increasing the lock time to
1000mssolves the problem and it will not affect the performance or the behavior.Suggestions from: mike-marcacci/node-redlock#65
Related Issue
Partially solve #519
Motivation and Context
How Has This Been Tested?
Tests provided
Screenshots (if appropriate):
Posted on #519